search

coldbox-modules / cborm

The ColdBox ORM enhancements for ColdFusion ORM & Hibernate. Make ORM not suck!
https://coldbox-orm.ortusbooks.com/
8 stars 17 forks source link

Lucee 5 abstract errors on ORMUtilSupport #19

Closed elpete closed 7 years ago

elpete commented 7 years ago

https://github.com/coldbox-modules/cbox-cborm/blob/development/modules/cborm/models/util/ORMUtilSupport.cfc#L11

This line prevents ColdBox from starting on Lucee 5. Not sure if it is a fix here or in WireBox, but wanted to create the issue nonetheless.

bdw429s commented 7 years ago

If I recall, Micha fixed the issues with this in Lucee fairly recently. The problem was that when Wirebox tried to get metadata for the CFC with getComponentMetadata(), Lucee would instantiate the component in the background which would throw an exception since the component was abstract.

Here we go: https://luceeserver.atlassian.net/browse/LDEV-1042 Looks like he rolled out the fix in Lucee 5.1.1.1.

That said, it might not hurt for us remove that for now just to prevent people on Lucee 5.0 or 5.1.0 from getting errors.

lmajano commented 7 years ago

THat was committed by Micha himself a while back. I see no point in it, we can remove it.

lmajano commented 7 years ago

it is building right now. It has auto-publish so all we need to do for a release now is make sure we merge to master