search

coldbox-modules / cborm

The ColdBox ORM enhancements for ColdFusion ORM & Hibernate. Make ORM not suck!
https://coldbox-orm.ortusbooks.com/
8 stars 17 forks source link

fix: Improve Hibernate version detection and switch to Github Actions #40

Closed michaelborn closed 3 years ago

michaelborn commented 3 years ago

Adds a method of correctly and accurately determining the Hibernate version regardless of CFML engine. Previously, a Lucee environment was assumed to indicate Hibernate v3.x. (Which is no longer the case with the new version of the Lucee Hibernate extension.)

lmajano commented 3 years ago

This is great. Can you add tests for each engine so we can verify the detection works.

michaelborn commented 3 years ago

That's a big Can-Do @lmajano !

michaelborn commented 3 years ago

Alright - @lmajano I was able to get a Github Actions build working, which verified that this PR broke the SQLHelper's formatter on Lucee. :facepalm: I fixed the PR and included my Github Actions build while I was at it. If you think it looks good, I think we're good to go on this! :smile:

michaelborn commented 3 years ago

Closing this PR, it got a little messy with the Github Actions build in place as well.