search

coldbox-modules / cborm

The ColdBox ORM enhancements for ColdFusion ORM & Hibernate. Make ORM not suck!
https://coldbox-orm.ortusbooks.com/
8 stars 17 forks source link

CBORM-34 #55

Closed jclausen closed 2 years ago

jclausen commented 2 years ago

Resolves CBORM-34 - Fixes an issue where SubQueries was being created as a singleton. The root cause of this issue is due to WIREBOX-126.

Because SubQueries extends a singleton, the scope="noscope" attribute was not being picked up because the singleton attribute is evaluated on line 550 of Mapping.cfc with an else-if to the scope, which is next in line.

jclausen commented 2 years ago

The Wirebox issue was actually caused by this commit in @be of Coldbox: https://github.com/ColdBox/coldbox-platform/commit/527b8ce800cb1beff6d8eaffefbfc18e273bbeb8#diff-205ec3bd7c7d061eb99964dedbefd07aaed4f636144957f54274967b1a8464b4R548

This PR can be discarded if the if/else block is reverted to just subsequent ifs. I have confirmed that CBORM-34 does not occur on coldbox@6.6.1 but does occur in the current coldbox@be

jclausen commented 2 years ago

Closing as this Coldbox PR resolves: https://github.com/ColdBox/coldbox-platform/pull/524