coldbox-modules / cbwire

CBWIRE is a ColdBox module that makes building reactive, modern apps easy using HTML-over-the-wire technologies and CFML.
https://cbwire.ortusbooks.com
Other
28 stars 5 forks source link

👌 IMPROVE: Fix build:docs script, other small updates #65

Closed michaelborn closed 2 years ago

michaelborn commented 2 years ago

This PR corrects a few bugs in the build:docs box script:

  1. An error when running box run-script build:docs because variables.exportsDir doesn't exist.
  2. The directoryCreate( outputDir ) is worse than useless, since DocBox creates this dir for you, and this code creates the wrong directory anyway! (it creates .tmp/apidocs/ inside the build/ directory, which is not where it should be.)

Also adds some file exclusions to the package zip excludes list.

grantcopley commented 2 years ago

@michaelborn I'm seeing merge conflicts on this

michaelborn commented 2 years ago

@michaelborn I'm seeing merge conflicts on this

Sorry - looks like my branch was out of date, and the CFFormat build messed it up.

michaelborn commented 2 years ago

@grantcopley I fixed the merge conflict with a force push. (Ssshh! :shushing_face: ) :grin:

The CFFormat task is still failing, but that's a separate issue and I don't think I'll ever get it working, actually.