Closed thierryvolpiatto closed 8 years ago
@thierryvolpiatto
Some people dosen't want to use linum-relative
in helm-buffer (issue: #21), is this PR suite their need?
I add the linum-relative-with-helm
due to issue #21, if this PR will not affect to others I'll happy to merge it.
Yen-Chin,Lee notifications@github.com writes:
@thierryvolpiatto Some people dosen't want to use linum-relative in helm-buffer (issue:
21), is this PR suite their need?
I don't know, what I know is this variable prevent only linum-relative to work correctly in helm buffer, but don't prevent using linum-relative (actually the situation is that when the variable is non-nil, the default linum-relative is just working, but badly in helm-buffer). Not a big problem to enable it, but well the default is not so good IMO.
Just my opinion ;-)
Thanks.
Also note that the error people have on issue #21 is only due to a bad installation of helm and have nothing to do with the code for helm introduced in linum-relative.
I think I can merge this PR after review the #21 and your code. Hope everyone like it :) Anyway, thanks for your contribution.
Yen-Chin,Lee notifications@github.com writes:
I think I can merge this PR after review the #21 and your code. Hope everyone like it :)
Great, thanks!
Also, now users don't have the "global" problem, they can turn on linum-relative locally without turning it on in other buffers, helm or whatever.
linum-relative-with-helm
is not disabling linum-relative for helm, it is just making linum-relative not working at all in helm. Without this users will have a better experience, having linum-relative working fine while in helm or not. It is BTW maybe not needed, the actual code doesn't affect other modes or buffer when not using helm. Please consider removing linum-relative-with-helm.Thanks.