search

cole-trapnell-lab / cicero-release

https://cole-trapnell-lab.github.io/cicero-release/
MIT License
56 stars 14 forks source link

Speed improvement in make_cicero_cds function. #16

Closed shamoni closed 5 years ago

shamoni commented 5 years ago

Profiling showed that in large >1k 10x datasets this function took over an hour to complete due to an expensive operation in the lapply loop. I modified the function to avoid this expensive code path while still obtaining the same matrix.

hpliner commented 5 years ago

PR

hpliner commented 5 years ago

Thanks for submitting this and sorry for the delay. If the new build finishes without issue, I'll merge!