cole-trapnell-lab / cicero-release

https://cole-trapnell-lab.github.io/cicero-release/
MIT License
56 stars 14 forks source link

make_atac_cds: fData(atac_cds)$chr <- as.numeric(as.character(fData(atac_cds)$chr)) #3

Closed cbravo93 closed 6 years ago

cbravo93 commented 6 years ago

Hi,

If having sex chromosomes ('X', 'Y') this line in make_atac_cds results in the chromosome name stored as NA, which results in further errors later on. Changing it to fData(atac_cds)$chr <- as.character(fData(atac_cds)$chr) seems to work.

Cheers!

hpliner commented 6 years ago

Good catch! Should be fixed now!