search

cole-trapnell-lab / cicero-release

https://cole-trapnell-lab.github.io/cicero-release/
MIT License
55 stars 15 forks source link

run_cicero multicore #70

Open skilpinen opened 3 years ago

skilpinen commented 3 years ago

I am exploring is there any way to run cicero faster, and noticed that within the code there is call to parallel::mclapply() but with hardcoded to mc.cores=1. Without reading through the entire logic there, just thought as that is here any possibility to run it faster?

hpliner commented 3 years ago

Hello, As I recall, I ran into inconsistent crashes when running with multicore which is why I ultimately hard coded it to 1. This was several years ago, so it's possible that glasso has been modified to be thread safe. I don't have time currently to try again on this, but if you'd like to give it a try and submit a pull request I'd be happy to review it.