search

cole-trapnell-lab / cufflinks

Boost Software License 1.0
310 stars 116 forks source link

Follow PEP 0394 and use Python2 explicitly #40

Closed xrobin closed 6 years ago

xrobin commented 9 years ago

One system I'm using has both Python 2.7 and 3.4 installed. Invoking of python without any version specification starts version 3.4, despite the recommendation of PEP 0394. On this system, cuffmerge crashes with a syntax error.

PEP 0394 also recommends that scripts that are not compatible with both Python 2 and 3 specify which version of Python should be used:

*In order to tolerate differences across platforms, all new code that needs to invoke the Python interpreter should not specify python, but rather should specify either python2 or python3 [...]

This push request specifies python2 in the shebang of the two scripts using python I could find, namely cuffmerge and cuffdiff_to_gct.py.

All the systems I have ever seen have python2 as a symbolic link to python 2.X. However this might not be universally true so you may want to consider this pull request carefully.

wookietreiber commented 9 years ago

:+1:

greysAcademicCode commented 8 years ago

:+1: