search

cole-trapnell-lab / garnett

Automated cell type classification
MIT License
104 stars 25 forks source link

bug in get_feature_genes() function #22

Closed a-solovyev12 closed 4 years ago

a-solovyev12 commented 5 years ago

Hello,

I was running the get_feature_genes() function with test input and default parameters (as in tutorial) when the following error popped up: 

Error in do.call("cbind", feature_genes) : second argument must be a list
Calls: get_feature_genes -> as.data.frame -> as.matrix -> do.call

Apparently, feature_genes is a vector rather than a list and just needs to be wrapped into a list function. Could you please fix this?

Thanks!

hpliner commented 4 years ago

Thanks for the report, I believe this is now fixed in the latest version. Please reinstall and give it another try!

a-solovyev12 commented 4 years ago

@hpliner, thanks a lot for fixing this. Could you please make a release with an updated version? We built a command line interface for Garnett as a bioconda package and need to update the recipe.

hpliner commented 4 years ago

@a-solovyev12 Sorry for the delay, I just created a new release, 0.1.13

a-solovyev12 commented 4 years ago

@hpliner, thank you :)