Postgrest ingress.hosts.paths should be paths: [/] instead of paths: []

colearendt / helm

Helm charts for miscellaneous services that I use regularly

5 stars 3 forks source link

Postgrest ingress.hosts.paths should be paths: [/] instead of paths: [] #30

Closed yevon closed 2 years ago

yevon commented 2 years ago

I think that ingress.hosts.paths in default values.yaml should be paths: [/] instead of paths: []

If not, I was getting error messages.

colearendt commented 2 years ago

Yeah, that makes sense. Right now the default values force you to set it. However, the downside of setting a default is I need to be sure whether it is tricky at all to unset the value for someone who doesn't like the value (I think paths: [] would just append, but maybe paths: null would work).

In any case, thanks for reporting! I will take a look!

yevon commented 2 years ago

I just tried this and it wasn't working:

  paths:
    - /

I had this already working in other helm installs, but for this postgrest chart it failed saying that the paths value didn't pass the regepx validation.