search

colearendt / tidyjson

Tidy your JSON data in R with tidyjson
Other
182 stars 14 forks source link

Fix DROP=TRUE bug in tbl_json #100

Closed colearendt closed 5 years ago

colearendt commented 7 years ago

DROP=TRUE does not work (because the object ceases to be a tbl_json object). I also argue that it should not, in order to be consistent with the tbl_df class, which simply warns that the parameter is not acknowledged and then does nothing.

colearendt commented 5 years ago

Ever since tibble 0.6, drop=TRUE actually does work for tibble. I have to say I'm not a huge fan. However, by calling NextMethod(), we inherit this behavior and so are consistent. Closing.