search

coleifer / micawber

a small library for extracting rich content from urls
http://micawber.readthedocs.org/
MIT License
635 stars 91 forks source link

HTTPS Support for services (with tests) #5

Closed dokterbob closed 12 years ago

dokterbob commented 12 years ago

While working on a project I found out that at least YouTube wasn't working with HTTPS.

So I updated the regexp's to include it and added a (conditionally executed) test for the movie from the README (in which I found an error) and the HTTPS variant thereof.

coleifer commented 12 years ago

Thanks for pointing this out. I think the simplest solution is the best, which would just be to modify the youtube provider to be more permissive. I prefer https?://... versus https{0,1}:// as well. Going to pass on the testcase as well since i'm -1 on network activity in a testcase.

dokterbob commented 12 years ago

So how 'bout the comma in the readme? ^^

dokterbob commented 12 years ago

Thanks BTW for the quick response!