coleifer / micawber

a small library for extracting rich content from urls
http://micawber.readthedocs.org/
MIT License
632 stars 91 forks source link

Packaging: examples conflict with flasgger #83

Closed dvzrv closed 6 years ago

dvzrv commented 6 years ago

There is a file conflict between flasgger and micawber, because both install files into the too generic path name examples. For reference, please see this Arch Linux bug.

As a solution, micawber and flasgger should either not install these examples at all, or if required into a unique directory (e.g. micawber-examples) or another system directory (e.g. on Linux: /usr/share/doc/python-micawber/examples, which is usually done by the packagers).

I will remove them for now to resolve the file conflict.

coleifer commented 6 years ago

I've modified the package data and pushed a new release, 0.3.6, which should address the issue. Thanks.

dvzrv commented 6 years ago

Hmm, there are still files being installed into the examples directory with 0.3.6:

usr/lib/python3.7/site-packages/micawber-0.3.5-py3.7.egg-info | usr/lib/python3.7/site-packages/examples/
usr/lib/python3.7/site-packages/micawber-0.3.5-py3.7.egg-info | usr/lib/python3.7/site-packages/examples/__init__.py
usr/lib/python3.7/site-packages/micawber-0.3.5-py3.7.egg-info | usr/lib/python3.7/site-packages/examples/__pycache__/
usr/lib/python3.7/site-packages/micawber-0.3.5-py3.7.egg-info | usr/lib/python3.7/site-packages/examples/__pycache__/__init__
usr/lib/python3.7/site-packages/micawber-0.3.5-py3.7.egg-info | usr/lib/python3.7/site-packages/examples/__pycache__/__init__
                                  > usr/lib/python3.7/site-packages/examples/django_ex/
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__init__.p
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/__pycache_
                                  > usr/lib/python3.7/site-packages/examples/django_ex/manage.py
                                  > usr/lib/python3.7/site-packages/examples/django_ex/settings.p
                                  > usr/lib/python3.7/site-packages/examples/django_ex/urls.py
                                  > usr/lib/python3.7/site-packages/examples/django_ex/views.py
                                  > usr/lib/python3.7/site-packages/micawber-0.3.6-py3.7.egg-info
                                  > usr/lib/python3.7/site-packages/micawber-0.3.6-py3.7.egg-info
                                  > usr/lib/python3.7/site-packages/micawber-0.3.6-py3.7.egg-info
                                  > usr/lib/python3.7/site-packages/micawber-0.3.6-py3.7.egg-info
                                  > usr/lib/python3.7/site-packages/micawber-0.3.6-py3.7.egg-info
coleifer commented 6 years ago

Shoot, you're right -- my bad. I missed the fact that setup.py was using find_packages(). I've actually tested it now and its working correctly.

0.3.7 / c31fb05943cd55514964804529eb6e0f14e46960

dvzrv commented 6 years ago

Haha, no worries. Thanks for the fast response!!