Fix issue with minute overwriting month in convert_timestamp, python >= 3.12

coleifer / peewee

a small, expressive orm -- supports postgresql, mysql, sqlite and cockroachdb

http://docs.peewee-orm.com/

MIT License

11.06k stars 1.37k forks source link

Fix issue with minute overwriting month in convert_timestamp, python >= 3.12 #2890

Closed lanceris closed 4 months ago

lanceris commented 4 months ago

In convert_timestamp() variables for month and minute were the same (m), which led to incorrect timestamp parsing.

This PR fixes it by renaming variables to month and minute respectively, as well as renaming other one-lettered variables in this function to make them more obvious.

coleifer commented 4 months ago

Oh man that's awful, thank you!