coleifer / pysqlite3

SQLite3 DB-API 2.0 driver from Python 3, packaged separately, with improvements
zlib License
189 stars 54 forks source link

Increase the host parameter limit #12

Closed evansd closed 4 years ago

evansd commented 4 years ago

This increases the maximum number of placeholders SQLite will accept. See: https://www.sqlite.org/limits.html#max_variable_number

By default it is set at 999, presumably because the default configuration needs to work with highly memory-constrained embedded devices. Most OS distributions of SQLite increase this number significantly. For example, on Ubuntu it is 250,000 and on OS X it is 500,000. See: https://launchpad.net/ubuntu/+source/sqlite3/3.8.0.2-1ubuntu1 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717900

evansd commented 4 years ago

pysqlite3-binary is absolute magic, by the way. Thanks so much for building it.

evansd commented 4 years ago

Ha, amazing! You merged this before my "temporary workaround" PR got merged on our own project :) Do you think you'll be able to cut a new PyPI release before long?

evansd commented 4 years ago

Oh you've already done it!

coleifer commented 4 years ago

I got you cuh - thanks for the patch.