search

coleifer / pysqlite3

SQLite3 DB-API 2.0 driver from Python 3, packaged separately, with improvements
zlib License
188 stars 53 forks source link

Don't use _Py_IDENTIFIER() APIs #32

Closed erlend-aasland closed 2 years ago

erlend-aasland commented 2 years ago

Resolves #31

erlend-aasland commented 2 years ago

Disclaimer: I haven't had the time to test (or even compile) these changes yet. I'll get around to doing that later today, but the changes are pretty straight-forward; it should work straight out of the box.

coleifer commented 2 years ago

I'm going to pass for now, but will reconsider it should the upstream APIs also change.

coleifer commented 2 years ago

FYI these are not merged, accidentally hit the merge button and force-pushed to restore the original head.

coleifer commented 2 years ago

There seems to be a few issues with these changes, even after I've got them compiling, so I'm going to return to my earlier stance:

I'm going to pass for now, but will reconsider it should the upstream APIs also change.