search

coleifer / pysqlite3

SQLite3 DB-API 2.0 driver from Python 3, packaged separately, with improvements
zlib License
192 stars 53 forks source link

Use manylinux2014 docker image #51

Closed AbdealiLoKo closed 1 year ago

AbdealiLoKo commented 1 year ago

Hey there, following up on https://github.com/coleifer/pysqlite3/issues/40#issuecomment-1523882073

I went through your code, and I realized the structure was super intuitive :+1: And before I knew it I was able to get the project working on manyinux_2_17 quite easily :)

So, decided to create a PR to use the manylinux2014 (aka manylinux_2_17) docker from pypa.

I tested this locally, and:

$ bash build.sh
... no errors ...

$ ls wheelhouse/
...
pysqlite3_binary-0.5.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

If this seems good, would be great to get this merged !

coleifer commented 1 year ago

Let me mull it over, the 2014 is expected to be EOL in January of next year. My feeling at the moment is that it'd probably be easier for you to fork pysqlite3 and register pysqlite3-binary-manylinux2014 or something on pypi and push these alternate wheels there.

AbdealiLoKo commented 1 year ago

Thanks @coleifer I have my own internal wheelhouse that I am already building. Not sure if I'll publish to pypi, but will be maintaining it internally for my machines running on amazonlinux

On a side note, wanted to mention that manylinux2010 will be end of life after July 2024: https://github.com/mayeut/pep600_compliance#acceptable-distros-to-build-wheels

coleifer commented 1 year ago

The pypa/manylinux readme, which I consider to be an "official" source, declares that manylinux2010 was end-of-life last year: eol

For now I'm going to hold off on merging this change.

AbdealiLoKo commented 1 year ago

@coleifer I think there is some confusion ...

I agree that 2010 is EOL. This PR was for 2014 which is not EOL

coleifer commented 1 year ago

Sorry yes, I was mixed up in my last comment. You are right about 2014 having a bit over a year left before EOL.

Nonetheless, and I'm sorry because I see the merit of your request, I'm going to hold off for the moment on any changes.