search

colejd / Waldorf

Annotation frontend for the Media Ecology Project
MIT License
8 stars 3 forks source link

Add author written name for attribution #2

Open novomancy opened 7 years ago

novomancy commented 7 years ago

Right now the display is only the mbox hash while the json includes the email address. The json should include a written name and the mbox hash, with only the written name rendering to the page. The email is still required for submission (to create the hash) but doesn't need to appear in the database or output.

colejd commented 7 years ago

I just tried to tackle this, and it seems to have a bit of complexity under the surface. When "logging in" during an API key based session, the user is only prompted for their email, which is the only user info passed to Statler. We can change Statler so that it accepts emails and names simultaneously, but then we run into the issue of presenting that in Waldorf.

Put simply, I think in order to do this, we're going to have to have a separate "create account" modal in Waldorf so that we can get the name and email registered, while being able to log in after that with just the email.

colejd commented 7 years ago

Something else I thought I'd note here: when Statler takes an annotation from an email address it's never seen before, it creates a new user in the DB with the name and email fields set as the email. See here for the relevant line.

If I remember correctly, there is no "real name" field in the DB. Statler will need some work for that.