search

colelawrence / Touch-Splitter-jQuery

A high performance html splitter compatible with touch events
14 stars 7 forks source link

Specify handlers when unsubscribing from events on destroy. #13

Closed WiseBird closed 7 years ago

WiseBird commented 7 years ago

At the moment when destroying one splitter others stop working because destroy removes all handlers from window's events. This should fix it.

colelawrence commented 7 years ago

Hi! Thanks for your contribution, would you be able to reopen this PR without updating the distributable?

I can generate the distributable upon merge :-)

WiseBird commented 7 years ago

Yes, sure

WiseBird commented 7 years ago

Done

WiseBird commented 7 years ago

Could you please bump version and update npm package?

colelawrence commented 7 years ago

Thank you for pushing on this WiseBird. I have released 0.6.0 just now with your contributions. Please do not hesitate to bring up further issues.

Le mer. 27 sept. 2017 à 00:44, WiseBird notifications@github.com a écrit :

Could you please bump version and update npm package?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/colelawrence/Touch-Splitter-jQuery/pull/13#issuecomment-332437891, or mute the thread https://github.com/notifications/unsubscribe-auth/ACyjUyBwWYRDJ_h9vKEeNr9-pyVeMDjRks5smfzFgaJpZM4PkINn .