search

colesbury / nogil

Multithreaded Python without the GIL
Other
2.91k stars 107 forks source link

Docker image for arm64 #136

Closed xbit18 closed 9 months ago

xbit18 commented 9 months ago

Hello, first time ever proposing something on Github.

Problem: Through experimentation I found that the docker method doesn't work for arm64 (Macbook Air M1 in particular).

Solution: I found that by changing the first line of the Dockerfile, which is: "FROM buildpack-deps:bullseye" to this: "FROM arm64v8/buildpack-deps:bullseye", the image then supports the arm64 architecture.

After building this local image, it can be used instead of the standard nogil/python that's on dockerhub.

It would be nice to publish this version too on dockerhub, maybe with a name like "nogil/pythonarm" to be more easily used. Those are my two cents, thanks!

colesbury commented 9 months ago

Hi @xbit18, my current focus is on getting the nogil changes upstreamed into the upcoming CPython 3.13 release, so I don't think I'll have time to add a Docker image for macOS arm64. I'd be happy to review a PR, though.

xbit18 commented 9 months ago

Hey @colesbury thanks for the quick reply! Yes, I'm following your work and actually writing a thesis on the subject :) I'd happily do a PR but what would I do? Perhaps I can add another Dockerfile for building this new image. It's my first contribution to an open source project so I'm sorry for the trouble of explaining this trivial stuff.

xbit18 commented 9 months ago

@colesbury nevermind, I looked at your workflows setup, I think I know what to do