search

colhountech / js2-mode

Automatically exported from code.google.com/p/js2-mode
0 stars 0 forks source link

namespace cleanliness nit #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I noticed this:

(defvar emacs22 (>= emacs-major-version 22))

It is a bit friendlier to always be namespace-clean.
I suggest renaming this to 'js2-emacs22' or the like.
Also, I noticed a couple explicit tests of the version elsewhere, eg:

  (if (>= emacs-major-version 22)
      (c-setup-paragraph-variables))

Original issue reported on code.google.com by t...@tromey.com on 18 Apr 2008 at 10:51

GoogleCodeExporter commented 8 years ago

Original comment by steve.ye...@gmail.com on 19 Apr 2008 at 9:01

GoogleCodeExporter commented 8 years ago

Original comment by steve.ye...@gmail.com on 19 Apr 2008 at 9:11

GoogleCodeExporter commented 8 years ago

Original comment by steve.ye...@gmail.com on 19 Apr 2008 at 10:55