search

coli-saar / am-parser

Modular implementation of an AM dependency parser in AllenNLP.
Apache License 2.0
30 stars 10 forks source link

Setup Docker environment. #97

Closed tsimafeip closed 2 years ago

tsimafeip commented 2 years ago

Hello! Here is a PR, which helps to setup Docker environment to am-parser.

alexanderkoller commented 2 years ago

This is cool. One question: Does this Docker environment support GPU acceleration? I remember that you had to use special Docker images from Nvidia if you wanted GPU.

tsimafeip commented 2 years ago

Yes, Docker supports GPU acceleration. You can need to set '--gpus' option for 'run' command. I have updated README to reflect it.

megodoonch commented 2 years ago

This is really helpful! I'm using this fork now, but I don't feel qualified to approve the merge. I am getting an error on train, but I have no idea if it has anything to do with this pull request. The line that's causing problems is also in the main branch.

jgroschwitz commented 2 years ago

I have manually added @megodoonch 's edit to specify the pytorch version (https://github.com/tsimafeip/am-parser/pull/1) in commit https://github.com/coli-saar/am-parser/commit/47c719d1df436c00c6eaf310d31c93340e9a9b99. (I did not include the formatting changes to unrelated files that were in that pull request)