search

colin-campbell / firestudio-catalina

Run unsupported PreSonus Firewire devices on Mac OS Catalina, Big Sur, Monterey and Ventura
39 stars 5 forks source link

Button issue persisting #16

Closed burkebot closed 1 year ago

burkebot commented 1 year ago

Hi, I'm getting the same button issue from the previous issue you closed. Using a Firestudio Project with Ventura 13.2.1

Is it possible this issue is still persisting on some devices?

colin-campbell commented 1 year ago

I don't have an Intel Mac to test on at the moment so I'm "flying blind", as it were. I shall try to get a test machine as soon as I can.

sorachan commented 1 year ago

Same here.

TL;DR: for the others – just use v0.4.0.

sorachan commented 1 year ago

And there's no need for testing, it indeed is just a brainfart from removing the 2626 as you already assumed.

Too lazy to open a pull request, that's why I'll explain it here:

in v0.4.0 you still had the choice between UC and 2626 and the result was stored in

const button = result.buttonReturned;

and you removed that line but you're still referencing it in

Progress.description = `Installing ${button}`;

so just replace it by

Progress.description = `Installing Universal Control`;

and everything should be fine.

(Many thanks for making the installer! I'm too broke to buy you a coffee so I hope we're cool now xD)

colin-campbell commented 1 year ago

I've made this change. Thanks sorachan, I shall close this.