specific versions of dependencies should be downloaded and not just the latest

colin-daniels / sp2

Computational condensed matter research code written in C++. Primary applications relate to low-dimensional carbon nanomaterials, phonons, and structural optimization.

0 stars 0 forks source link

specific versions of dependencies should be downloaded and not just the latest #13

Closed ExpHP closed 4 years ago

ExpHP commented 7 years ago

Upgrading to a new version of a dependency should be a deliberate act. It's an unpleasant debugging experience when the potential you're working with gets changed right under your nose. Also, jsoncpp is deprecating features that are apparently actively used in sp2.

colin-daniels commented 7 years ago

Actually, it's even worse than you think. At least for LAMMPS, it only checks for new versions when you do a complete clean of the build tree/cmake.

colin-daniels commented 4 years ago

Fixed by 612902fbeb28320411b12210387b20b7cb7c5161