colin-daniels / sp2

Computational condensed matter research code written in C++. Primary applications relate to low-dimensional carbon nanomaterials, phonons, and structural optimization.
0 stars 0 forks source link

ctrl-c doesn't work #23

Closed ExpHP closed 7 years ago

ExpHP commented 7 years ago

;_;

colin-daniels commented 7 years ago

I was pretty sure it used to work, and yeah, works in af65eb7ad47c7e53b801001c35d7dcd2d3ebe97e. Probably an issue with python and error handlers.

colin-daniels commented 7 years ago

Bug is somewhere in 65719379644b74b2d5025fb175f5770d33442efe (via git bisect).

colin-daniels commented 7 years ago

Seems like we want void Py_InitializeEx(int initsigs) with initsigs = 0. According to python docs:

This function works like Py_Initialize() if initsigs is 1. If initsigs is 0, it skips initialization registration of signal handlers, which might be useful when Python is embedded.

ExpHP commented 7 years ago

fixed on develop

ExpHP commented 7 years ago

not fixed on develop

ExpHP commented 7 years ago

actually fixed on develop (note: didn't verify)