search

colin-kiegel / rust-derive-builder

derive builder implementation for rust structs
https://colin-kiegel.github.io/rust-derive-builder/
Apache License 2.0
1.28k stars 82 forks source link

Move UninitializedFieldError to derive_builder #206

Closed TedDriggs closed 3 years ago

TedDriggs commented 3 years ago

UninitializedFieldError is part of the runtime API of derive_builder, not part of its compile-time macro machinery. Exporting it from the derive_builder_core crate caused downstream crates to unnecessarily import all of derive_builder_core, rather than only importing it via the proc-macro crate at compile-time.

Fixes #201

TedDriggs commented 3 years ago

@andy128k any idea why this fails when the original PR adding the test succeeds? I'm very unfamiliar with no_std.

TedDriggs commented 3 years ago

Filed an issue to bring back the removed test, so proceeding to merge.