search

colin-kiegel / rust-derive-builder

derive builder implementation for rust structs
https://colin-kiegel.github.io/rust-derive-builder/
Apache License 2.0
1.28k stars 82 forks source link

Re-introduce test crate for no_std environment #208

Closed andy128k closed 3 years ago

andy128k commented 3 years ago

Closes #207

TedDriggs commented 3 years ago

Will merge after CI passes.

andy128k commented 3 years ago

@TedDriggs The difference is huge! It was a binary crate and now it is a library crate.

What actually happened is that the crate was linked to the libstd. When you fixes the issue with a dependencies you also removed linkage of the crate with libstd and it broke. (This is an additional confirmation that your fix actually removed a dependency on libstd).

Now this crate is a lib (not a binary) and there is no linking process at all (excluding building of tests, but they imply libstd anyway).

Also, this "test" is less strict than the previous one. We may resurrect the old one (binary), but it will work on nightly only :(

TedDriggs commented 3 years ago

If you go back in the repo history you'll see that there was such a test at one point. Then it broke due to changes in nightly, nobody knew how to fix it, and eventually I deleted it because it hadn't worked in ages and was adding a bunch of complexity to the tests beyond cargo test --all.

Let's see if we have further problems with no_std; now that we know what to look out for, I think we'll be safe.