search

colin-kiegel / rust-derive-builder

derive builder implementation for rust structs
https://colin-kiegel.github.io/rust-derive-builder/
Apache License 2.0
1.28k stars 82 forks source link

added Eq, and PartialEq #257

Closed EvanCarroll closed 8 months ago

EvanCarroll commented 2 years ago

Derive Eq and PartialEq on BuilderError. #256

TedDriggs commented 2 years ago

My understanding is that generating unnecessary trait implementations can increase code size. Given that derive_builder is widely-used, there isn't a widespread need for these to impl Eq, and that there is an easy solution for crates that do want such a behavior, I'm disinclined to merge this.

EvanCarroll commented 2 years ago

Computer crashed, lost the message I typed. I've heard of things like that before. I was unconvinced, so I wanted to do my own research on it. You may find this informative. https://stackoverflow.com/q/72609905/124486