search

colin-kiegel / rust-derive-builder

derive builder implementation for rust structs
https://colin-kiegel.github.io/rust-derive-builder/
Apache License 2.0
1.32k stars 88 forks source link

Fix typo in custom setter documentation #270

Closed Adam-Gleave closed 2 years ago

Adam-Gleave commented 2 years ago

Thanks for the great work on this crate!

I found a typo while I was reading through the docs of this crate today, so this is just a tiny little PR to fix it.

Adam-Gleave commented 2 years ago

I've just taken a look at those CI errors and I can probably fix these tomorrow (in a separate PR) if there's a want for it -- it just looks like a couple of outdated bits.

TedDriggs commented 2 years ago

Ugh - I love Clippy, but I do hate how often PRs are forced to first submit a separate PR that plays catchup with new lints. I'll hit those now.

TedDriggs commented 2 years ago

Lot of things went wrong on the CI front. I'm now pushing an update to darling so that the 1.59 build will pass, and I'm going to file an issue to get the 1.40 build working again (see dtolnay/trybuild#203), and then finally we'll be able to get #272 to pass CI, which will fix the lint problem, and then we'll be able to see this pass CI and merge it.

TedDriggs commented 2 years ago

Okay, please try rebasing now

Adam-Gleave commented 2 years ago

Done, thanks. Lots of work for a little typo, was not my original intention!

TedDriggs commented 2 years ago

They were updates that needed doing - I'm glad we found out now instead of in another few months!