colin-kiegel / rust-derive-builder

derive builder implementation for rust structs
https://colin-kiegel.github.io/rust-derive-builder/
Apache License 2.0
1.35k stars 89 forks source link

Accept field(ty = "...") to ease migration to syn 2.0 #306

Closed TedDriggs closed 10 months ago

TedDriggs commented 10 months ago

On syn 2.0, field(type = "...") will break with a not-very-informative error message.

While we can't prevent that, we can make it possible for people to switch to the new property name without needing to change anything else, so that the eventual dependency version bump is fully source-compatible.

Alternatives Considered

I debated using DeprecationNotes to put a warning on all uses of type, but decided it wasn't worth the code churn necessary to plumb that through from the options area all the way to code generation. This is already a highly specialized feature, and the fix is pretty easy once you read the release notes.