More CSS changes - Githubissues

colin353 / mushu-new

0 stars 1 forks source link

More CSS changes #76

Closed colin353 closed 6 years ago

colin353 commented 6 years ago

Inventory view looks a lot better. I have pre-rendered cards in there too
Fixed some CSS issues introduced with the refactoring.
When you click a card, you get a popover. There isn't an interface on there, but eventually you will be able to see the cost and activate the card from there.
Lots of holes in this PR, but seeing as it is an improvement, I think it may be OK to merge anyway.

iteloo commented 6 years ago

The UI looks amazing. I added quite a bit of stuff and filled in the holes in the detailed view, so you should probably review the changes first.

colin353 commented 6 years ago

Sorry for the super delay in responding here. I've been on vacation + sick. I'm mostly back to life now though, so I'll review this and do some more work this weekend.

colin353 commented 6 years ago

Looks amazing. I've never heard of a zoomlist data structure before, haha, but it makes sense. I'm going to pull this in.

iteloo commented 6 years ago

It's normally called a zipper, and you can make one for any inductively defined data structure (for example, list and trees). I just named it zoom list to keep with your naming convention haha :P

iteloo commented 6 years ago

It think we should leave the PR number that Github inserts automatically in the commit message when we merge.

colin353 commented 6 years ago

Okay, I'll leave it in in the future.