add password hashing - Githubissues

colinbankier / realworld-tide

Rust / Tide example app following realworld.io

149 stars 26 forks source link

add password hashing #17

Closed Giesch closed 4 years ago

Giesch commented 4 years ago

resolves #2
avoids logging or returning passwords
adds some custom error types for the app/web boundary

I'd love to get feedback on this. I feel like there's probably a better way to do error handling, but I don't know the ecosystem well enough. I'm also not sure if the 'into PublicUser' conversion really belongs in the app or web layer.

colinbankier commented 4 years ago

Thanks for your contribution! I'll take a more detailed look over the next few days.

colinbankier commented 4 years ago

Thanks @Giesch - master has moved on a bit - would you like to rebase your changes on master so it can be merged in? In terms of error handing - there are many crates for handling this but just using enums as you've done is perfectly fine until it becomes obvious something else is needed.

Giesch commented 4 years ago

This resolves the merge conflicts and removes the 'public user' stuff that was basically duplicated.

colinbankier commented 4 years ago

Great, thanks for your contribution @Giesch :+1: