colinbendell / homebridge-blink-for-home

Blink For Home Camera Homebridge plugin
MIT License
89 stars 27 forks source link

Feedback on v3.9.0 #100

Open rcoletti116 opened 2 years ago

rcoletti116 commented 2 years ago

Hi Colin - thanks for a big update to the plugin. I really appreciate the work you put in here. This one has some significant changes and I wanted to provide some general feedback from testing so far.

Thanks again!

colinbendell commented 2 years ago

Thanks!

rcoletti116 commented 2 years ago
  • To make sure I understand your desire. You have, for example, a camera pointing in your backyard. You are home, so you don't want the motion alerts. But you want the periodic updated thumbnail when looking at it through the home app. Is that about right? (fwiw, I removed this specific part of the code because it was messy and hard to test the logic. I've done a bunch of refactoring, so it's not as bad and can probably add it back)

Pretty much! I also use the HomeCam app as kind of a dashboard and it pull thumbnails and shows multiple cams.

town3r commented 2 years ago

Happy to see this plugin is still being worked on!

Since updating my camera is stuck on Off.

Manually Disabled seems to be auto enabled.

Current settings:

 "hide-alarm": true,
            "hide-manual-arm-switch": true,
            "hide-enabled-switch": true,
            "hide-privacy-switch": true,
            "enable-liveview": true,
            "disable-thumbnail-refresh": false,
            "enable-startup-diagnostic": false,
            "platform": "Blink"
town3r commented 2 years ago

Ope, looks like it's causing homebridge to crash.

image

town3r commented 2 years ago

Apologies for all the responses.

I found that disabling the LiveView feature (which was working before) seems to resolve the issue with the thumbnail not loading and homebridge crashing

colinbendell commented 2 years ago

the live view should only be triggering if you tap into the camera. Homekit does get into a little bit of a state when it gets an error for loading the live view and takes a bit to refresh out of it.

pserbanp commented 2 years ago

Same for me all cameras are OFF. Thank you for continue developing

rcoletti116 commented 2 years ago

Arm the cameras to get them back "on".

gdotp01 commented 2 years ago

Good to see this is still being worked on. Thanks for your efforts.

I’ve updated and all cameras (all 6) seem to be off and don’t change from this even if the system is armed.

670E361C-D661-4D4C-B289-079E56C31F52

pserbanp commented 2 years ago

Good to see this is still being worked on. Thanks for your efforts.

I’ve updated and all cameras (all 6) seem to be off and don’t change from this even if the system is armed.

670E361C-D661-4D4C-B289-079E56C31F52

Did any of you manage to enable cameras with 3.9.0 ? If I downgrade they are enabled and working ! Simply does not meter if is armed or not there is now streaming working

town3r commented 2 years ago

I was having the same issue and after disabling the Live Feed feature and making sure the system was armed in the Blink app. (Wish the cams could still be online even if not armed). It seemed to start working.

Also check the HomeKit Recording options for each camera. Not sure if those settings matter much. Just make sure they're not set to Off.

Here's my config:

{
            "name": "Blink",
            "username": "xxxxx@gmail.com",
            "password": "xxxxxxxxxx",
            "pin": xxxxxxxxxx,
            "hide-alarm": true,
            "hide-manual-arm-switch": true,
            "hide-enabled-switch": true,
            "hide-privacy-switch": true,
            "enable-liveview": false,
            "disable-thumbnail-refresh": false,
            "enable-startup-diagnostic": false,
            "platform": "Blink"
        }
gdotp01 commented 2 years ago

I can’t get it to work at all I’m afraid. It does allow me to turn them on/off but getting no thumbnails. I’ve set up each camera to “streaming” within HomeKit.

gdotp01 commented 2 years ago

I’ve returned to the previous version and it’s working as expected again

colinbendell commented 2 years ago

Change the camera to 'detect activity' to avoid the camera from attempting to stream. Streaming is broken in general (see comments in other threads about the proprietary steraming format), and a bit more broken in this release.

The thumbnails should then show up after disabling the camera and re-enabling it.

gdotp01 commented 2 years ago

I’ve updated and set to Detect activity rather than streaming. However still no thumbnails. I’ll cameras are blank and say “detect activity”. I’m not sure what you mean when you say disable the cameras , where would I do this ?

EE2C1520-F0F2-43A8-B148-EC33674AE1F8

colinbendell commented 2 years ago

Ah sorry, I didn't realize homekit turns off the thumbnails when you do that. The best way I have found to reset homekit's polling of the thumbnails is to either 'disarm then arm' the cameras using the switches, or temporarily disable the plugin (restart homebridge, re-enbable the plugin). There are many reddit threads discussing this.

The alternative is that I set up a passive RSTP stream so that live view appears to be working, even though it is not.

StaRipper commented 2 years ago

Same here.

gdotp01 commented 2 years ago

I’ve tried every way I can think of to get this to work but eventually I’ve gone back to the previous version I’m afraid

1PlusN commented 2 years ago

I'm having a pain of a time with the cameras too but its on 3.9.1. The Camera shows as disables or off sometimes and other times I get a thumbnail refresh (not per the refresh rate setting though). I just enables the logging, and the getSirens() seems to be throwing an error. [11/04/2022, 21:29:33] [Blink] GET /sirens (404 Not Found) [11/04/2022, 21:29:33] [Blink] GET /sirens [11/04/2022, 21:29:33] [Blink] Error: GET /sirens (404 Not Found) at BlinkAPI._request (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink-api.js:342:23) at processTicksAndRejections (node:internal/process/task_queues:96:5) at BlinkAPI.get (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink-api.js:228:16) at BlinkAPI.getSirens (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink-api.js:1114:16) at anonymize (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink.js:469:25) at BlinkHAP.diagnosticDebug (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink.js:507:13) at HomebridgeBlink.setupBlink (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:112:59) at HomebridgeBlink.init (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:41:26) [11/04/2022, 21:29:33] [Blink] TypeError: Cannot read properties of undefined (reading 'replaceAll') at anonymize (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink.js:472:33) at processTicksAndRejections (node:internal/process/task_queues:96:5) at BlinkHAP.diagnosticDebug (/usr/local/lib/node_modules/homebridge-blink-for-home/src/blink.js:507:13) at HomebridgeBlink.setupBlink (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:112:59) at HomebridgeBlink.init (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:41:26) [11/04/2022, 21:29:33] [Blink] Error: Blink Authentication failed. at HomebridgeBlink.setupBlink (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:116:19) at processTicksAndRejections (node:internal/process/task_queues:96:5) at HomebridgeBlink.init (/usr/local/lib/node_modules/homebridge-blink-for-home/src/homebridge/index.js:41:26) [11/04/2022, 21:29:33] [Blink] NOTE: Blink devices in HomeKit will not be responsive.