search

colinbendell / homebridge-blink-for-home

Blink For Home Camera Homebridge plugin
MIT License
87 stars 27 forks source link

blink.js: Add null check in thumbnail loader to avoid process crash #137

Open nicholaschum opened 1 year ago

nicholaschum commented 1 year ago

Thumbnails are crashing the process, and it seems that it is due to a null object being called upon.

TypeError: Cannot read properties of null (reading 'replace')

Refer to tickets #135 #120 #110

Tested on my Homebridge server and I am able to obtain Thumbnails again. Although not the best as we are limited by the Blink API, this restores functionality to the Homebridge plugin.

EdouardF commented 11 months ago

@colinbendell can you please merge this PR?

EdouardF commented 11 months ago

Hey @nicholaschum, I'm working on forking this repo and publish it to Homebridge via npm: https://github.com/EdouardF/homebridge-amazon-blink Please feel free to create a PR there and I'll merge it when I receive it. This repo seems dead, trying to fork it to revive it. Feel free to contribute as much as you please! Ed

nicholaschum commented 11 months ago

Hey @nicholaschum, I'm working on forking this repo and publish it to Homebridge via npm: https://github.com/EdouardF/homebridge-amazon-blink

Please feel free to create a PR there and I'll merge it when I receive it.

This repo seems dead, trying to fork it to revive it. Feel free to contribute as much as you please!

Ed

Sounds good. I'll run a PR over at your repo later today