search

colinbendell / homebridge-blink-for-home

Blink For Home Camera Homebridge plugin
MIT License
88 stars 27 forks source link

replace fetch-h2, add error handling and make motion polling configurable #46

Closed davidrthomas closed 3 years ago

davidrthomas commented 3 years ago

Hi, firstly thanks for the great plugin! I have been running a few fixes locally for a few weeks, would be great if they could be merged into the main version of the plugin.

  1. fetch-h2 has some known issues fixed in the adobe fetch fork (see here https://github.com/adobe/helix-fetch/issues/103). Note since this there is a v2 of adobe fetch which is a complete re-write. This change uses v1 the fixed fork of fetch-h2.

  2. Add error handling to the poller. If there is a network issue it kills the poller so add a simple try catch to prevent this.

  3. Make motion poller time configurable, I found 20s too high.

Thanks David

donavanbecker commented 3 years ago

@colinbendell yes can we please have this merged?

Plus #37 And #45

colinbendell commented 3 years ago

all changes have been merged

donavanbecker commented 3 years ago

@colinbendell Thanks!