search

colinbendell / homebridge-blink-for-home

Blink For Home Camera Homebridge plugin
MIT License
88 stars 27 forks source link

ffmpeg processes left running #5

Closed crowston closed 3 years ago

crowston commented 3 years ago

I noticed this morning that three ffmpeg processes were left running. Sorry, I don't have any details about how that happened. That was with version 3.5.5 though, so maybe no longer a problem.

colinbendell commented 3 years ago

yea. I just put the stock homebridge video accessory in place and it appears to go rogue. I've noticed this behavior myself and hoping that once I get back to liveview implementation I'll clean that up too.

vdrover commented 3 years ago

Is this related perhaps? I see a preview of the camera as expected: image But if i click on the thumbnail, i get this: image

colinbendell commented 3 years ago

no, the preview is a thumbnail (jpg) that uses different apis. It's the live camera delegate that is spawning and not tracking the ffmpeg process. The code that's in there is completely temporary

On Fri, Oct 30, 2020 at 5:29 AM Victor Drover notifications@github.com wrote:

Is this related perhaps? I see a preview of the camera as expected: [image: image] https://user-images.githubusercontent.com/3143313/97688584-4fa3fc00-1a68-11eb-91b4-260b261421c3.png But if i click on the thumbnail, i get this: [image: image] https://user-images.githubusercontent.com/3143313/97688624-60ed0880-1a68-11eb-96ef-c97d7eb18216.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/colinbendell/homebridge-blink-for-home/issues/5#issuecomment-719444581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMMERPUDPSFIYAGMTV27KLSNKBOBANCNFSM4S7I2ESQ .

vdrover commented 3 years ago

Understood. Happy to test subsequent versions.

colinbendell commented 3 years ago

liveview is still not ready, but I think the zombie ffmpeg bug is at least fixed in the interim.

crowston commented 3 years ago

Thanks for the update. A minor glitch: I have the privacy switch hidden, but am getting the privacy mode image for two of the cameras, which maybe not coincidentally are the ones that aren't armed. I am seeing the preview for one camera, which is also one that's armed.

colinbendell commented 3 years ago

not sure it properly worked in the first place. now fixed. live view now works as well

crowston commented 3 years ago

I just tried it out and wow, works great! Thanks for your efforts!

ratsoid commented 3 years ago

oh wow @colinbendell do you by any chance have a paypal account? I would really love to buy you a couple of beers

vdrover commented 3 years ago

Live view working well it seems for v3.5.13. Previews on the Home page of the Home app working well also, including thumbnail updates.

NiallBellxD commented 3 years ago

First off, excellent work on this Plugin Colin, it's great!

I just wanted to drop a message on here to say that each time a camera is clicked in the home app, an ffmpeg process is launched on my mac mini & it thrashes the CPU. Is there a way to have these processes kill themselves?

Cheers!

2014 MPB (macOS Catalina) Homebridge v1.1.7 Blink Plugin v3.6.2

colinbendell commented 3 years ago

I've overhauled some of the ffmpeg logic. more needs to be done. but it should address all the major issues with ffmpeg running for long periods of time.