colindamelio / saraswati

2 stars 0 forks source link

Mobile navigation does not work on Firefox #30

Closed nsbtr closed 6 years ago

nsbtr commented 6 years ago

Describe the bug The menu does not expand when the menu icon is clicked. The navigation element appears to be there, but this may just be an issue with positioning.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

johnathanfong commented 6 years ago

@nsbtr I haven't figured out the solution, but I don't think this is positioning related. The onClick handler is not firing in Firefox. You can tell because the menu button doesn't toggle icons.

johnathanfong commented 6 years ago

Resolved (https://github.com/colindamelio/saraswati/commit/9b1214052b5eb3a16fdc42709071c2ac0d29cdb5)