search

colindamelio / saraswati

2 stars 0 forks source link

Prod: Router throws a 404 on refresh #40

Closed JesseNoseworthy closed 6 years ago

JesseNoseworthy commented 6 years ago

Describe the bug

In Production, React-Router throws a 404 on refresh.

To Reproduce Steps to reproduce the behavior:

  1. Go to prod
  2. Navigate to any route
  3. Refresh the page
  4. Observe a 404 page

Expected behavior The page refreshes

johnathanfong commented 6 years ago

I mentioned this to @colindamelio already, but right now the error message when someone clicks Apply Now is really awkward, esp since this CTA is our number 1 priority right now. I definitely think the fix to prevent routes from breaking on refresh is great, but we'll need to update these landing page CTAs to redirect to the APPLY page, or to have a better long-term fix.

cc @JesseNoseworthy

update: I fixed this. Should be on prod momentarily.

johnathanfong commented 6 years ago

This has been fixed! (Along with some other small styling bugs I noticed).