If values are numbers/booleans don't tokenize them into strings.

colindembovsky / cols-agent-tasks

Colin's ALM Corner Custom Build Tasks

MIT License

83 stars 65 forks source link

Open MathewBerg opened 3 years ago

MathewBerg commented 3 years ago

Don't tokenizine things that aren't strings. This will convert

{
    "string": "string",
    "number":  5,
    "boolean": false
}

Into

{
    "string": "__string__",
    "number":  __number__,
    "boolean": __boolean__
}

Which will allow values like false/true/5/etc... to be added in later. It is invalid JSON though.

MathewBerg commented 3 years ago

Also should we maybe have it be a flag? I could see this potentially breaking some current tokenizations for people.