search

colindembovsky / cols-agent-tasks

Colin's ALM Corner Custom Build Tasks
MIT License
83 stars 67 forks source link

Tag Cross-Project Build on Release Errors #88

Closed T-Burnius closed 6 years ago

T-Burnius commented 6 years ago

Great tools! Works great for tagging a release but we have our builds in a separate project.

https://github.com/colindembovsky/cols-agent-tasks/blob/ab91fc9ad713fe1b8ceaafcdb9cc5741c8029661/Tasks/TagBuild/tagBuild.ts#L24

If used in a release, the System.TeamProject variable is tied to the project that the release is created under.

Since my build is contained in a different project from the release, the addbuildtags function call on line 73 fails with: ##[error]TypeError: Cannot read property 'join' of undefined

I think using Build.ProjectName will support cross-project functionality for builds, but it should stick with System.TeamProject for releases.

colindembovsky commented 6 years ago

Thanks @T-Burnius for pointing this out. Just when you think you've thought of all the scenarios... I've fixed this in 1.3.14 in this commit: 1bf44ea931659d4b63b92c764dc16015bff6982e