colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

Highlighted bold/italics text: spurious spaces in Live Preview #111

Closed lebigot closed 1 year ago

lebigot commented 1 year ago

Hello,

In Live Preview, bolded and italicized words are displayed with spurious spaces on each side.

Example: ==There are spurious spaces around **bolded and italicized words**: _look_!==

Screenshot 2022-12-29 at 22 01 52

This can be troubling, because it looks like the source has spurious spaces.

The default theme displays this correctly.

PS: another problem is that in Live Preview, the markdown marks (** and _) are not visible, in dark mode, in highlighted text:

Screenshot 2022-12-29 at 22 05 49

Should I open another issue?

Thanks!

colineckert commented 1 year ago

Hi @lebigot, thanks for creating this issue. This spacing bug with nested formatting was introduced by a recent change to add padding for highlights. Agree that it doesn't look great. I'll revert.

The markdown marks are dimmed to add focus on the styled text rather than the marks themselves. In dark mode in highlights, this can be hard to see. This was more relevant before Live Preview. I'll try to improve this experience.

colineckert commented 1 year ago

hey @lebigot, I just pushed an update to address these issues. Pls update your theme and if all looks good, pls close this issue. thanks!

lebigot commented 1 year ago

Perfect! Thank you so much for the fast turnaround and the great final result!