colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
707 stars 60 forks source link

Command palette active row does not use the accent color #124

Closed pdolezal closed 1 year ago

pdolezal commented 1 year ago

I set my favorite color as the accent color and the whole UI uses it to highlight buttons etc. Just the command palette and quick switch do not. Instead, they show the active row always in the same blue color.

I suppose the problem lies here:

.theme-dark .modal-container .suggestion-item.is-selected {
  background: var(--blue);
}

I worked around the problem with a custom CSS patch that applies --color-accent instead, which I'd suggest as the fix. I assume that it is rather a mistake that here a hard-wired color is used, while all important colors can be customized.

colineckert commented 1 year ago

Hey, @pdolezal thanks for creating this issue. Yeah, this was added back before there was support for user-defined accent colors. I just pushed up your suggestion as I totally agree. Lmk if you find any bugs. Otherwise, pls close this issue. Thanks!

pdolezal commented 1 year ago

Great! Thank you! 👍