search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
707 stars 60 forks source link

Add checkboxes for draft, open, and merged PRs #132

Closed lukasschwab closed 1 year ago

lukasschwab commented 1 year ago

Hi @colineckert — thanks for your work on this theme! This is a totally speculative PR, and you should feel free to close it (e.g. on the grounds that it adds checkbox styles unique to this theme).

Changes

Adds three new checkbox styles for typical GitHub workflows:

Uses MIT-licensed icons ("Octicons") from GitHub Primer:

Screenshot 2023-05-12 at 7 11 21 PM

Unfortunately, these aren't captured in the README.md screenshot yet.

Motivation

I use Obsidian at work, and work involves submitting PRs. Draft and open PRs are both partially completed tasks, but they're meaningfully different workflow states (blocked on me, blocked on a reviewer).

Using - [/] obscures that distinction!

I realize exhaustively adding checkboxes — for every workflow, or even just for developer workflows — would clutter this library. Set the limit where you see fit!

lukasschwab commented 1 year ago

I can also distribute this as a snippet. Feel free to close this PR!

lukasschwab commented 1 year ago

Closing: stale.

colineckert commented 1 year ago

@lukasschwab thank you for opening this PR! sry for the delay, i've been traveling lately but i really want this so am reopening this PR, and after testing will merge. thanks again!

lukasschwab commented 1 year ago

@colineckert oh, sweet! No worries about the delay, glad this turned out to be useful 😁

steynh commented 1 year ago

Hi all, wonderful addition to the theme, I just raised this feature request https://github.com/colineckert/obsidian-things/issues/140 before noticing this PR and that this is a very recent addition. Would you mind making this so that the [M] checkbox text is grayed out similar to the [x] checkbox?