colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
746 stars 64 forks source link

heading 2 bottom border is missing #137

Closed agung2001 closed 1 year ago

agung2001 commented 1 year ago

Environment

Screenshot

Screenshot 2023-06-03 at 06 23 03

Problem

It seems that the bottom border is missing

Solution

I notice that u use h2 when styling the heading theme.css#LL296C1-L296C61 m not sure what happened but it seems the latest version of Obsidian doesn't use h2 for the heading it uses div instead Screenshot 2023-06-03 at 06 29 19 maybe change theme.css#LL296C1-L296C61 to :

body .HyperMD-header.HyperMD-header-2.cm-line {
  border-bottom: 2px solid var(--background-modifier-border);
  width: 100%;
  padding-bottom: 2px;
}

it fixes the issue for me

I really like your theme man, thanks for sharing @colineckert 😄👍 Also how about setting up sass? I think it'll help with the development of this theme

colineckert commented 1 year ago

hey @agung2001 sry for the delay! are you sure you don't have any other styling on the h2? i have the same theme and Obisdian versions and this is not an issue on my end.

Screenshot 2023-06-04 at 5 17 46 PM

also, are you using the style settings plugin? check you don't have the h2 underline toggle disabled

Screenshot 2023-06-04 at 5 18 32 PM

yep, thought about sass! good idea, just haven't had the time to explore futher

agung2001 commented 1 year ago

omg, thanks. the style settings plugin help. now it works like a charm 😄👍

well for the sass, actually I can help you with that. I can create a fork for this repo and integrate sass do u want me to do it?

colineckert commented 1 year ago

awesome, glad that fixed it! i'll close this issue. and sure, go for it. fork and create a PR and i will review it :)