colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

Code Syntax highlighting is messed up all of a sudden. #147

Open omarcevi opened 1 year ago

omarcevi commented 1 year ago

Hello,

After updating to the last version of the theme, my code blocks syntax highlighting is all messed up and showing mainly 1 colour.

Screenshot 2023-09-02 at 20 51 29

anybody facing the same issue?

Edit: This was the syntax before i updated

Screenshot 2023-09-02 at 20 59 44
omarcevi commented 1 year ago

Yeah so i manually reverted to an older version (2.0.0) and the syntax was back normal.

colineckert commented 1 year ago

hey @lukasschwab and @omarcevi, thanks for creating the issue. i just released a new version of the theme that should address some of your concerns with syntax highlighting: https://github.com/colineckert/obsidian-things/releases/tag/2.1.15

lmk if this looks better and if so, pls close this issue. thanks!

lukasschwab commented 1 year ago

Hi @colineckert — this is my first time seeing this thread. Was there something you wanted me to look at?

colineckert commented 1 year ago

oops sorry @lukasschwab. you're good, i @ you by accident.

omarcevi commented 1 year ago

Yeah its fixed now closing the ticket :)

omarcevi commented 1 year ago

Hello again, the code blocks are all fine in the editing view, but they're not in the reading view. It affects the publish feature. the syntax coloring is not the same.

svenblum commented 6 months ago

I can confirm the issue. Editing is fine, viewing is single-color (red) only. Would be great to have this fixed.

Edit: I just realized that it's depending on the language. So it's only half-broken :-) See attached screenshots Edit2: I think it takes two different sources for the coloring. The "-m" which has a darker brown in edit-mode is not colored differently in bash. Edit3: My iterm2 with https://github.com/zsh-users/zsh-syntax-highlighting renders different colors. Maybee it could be nice to select the desired "color-scheeme"? but I think I'm asking too much here...

CleanShot 2024-04-10 at 08 15 58@2x CleanShot 2024-04-10 at 08 16 12@2x CleanShot 2024-04-10 at 08 34 39@2x