search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

Mobile app Highlight colour not changing #162

Open prwnr opened 9 months ago

prwnr commented 9 months ago

Hello,

I have a problem with the colour change for Highlights on iPad/iPhone, that keeps itself with the default, even tho I changed it to different colour.

Here is the setting:

image

And here the colour in action:

image

Why this is odd to me and I'm reporting this, is that on the MacOS version the colour of highlight is correct: image

Is there anything I could try to force change the colour on the mobile app? I tried theme reinstall, setting the colours back to originl, uninstalling it, reinstalling it. Tried to set the colour on the iPad/iPhone first and it still all is to vain, as the colour stays yellow. The same problem is regardless of the "view mode".

colineckert commented 8 months ago

hey thanks for creating the issue @prwnr! i've looked into this one and am able to repro. not sure of the exact cause tho. nothing in the css specifies different behavior between mobile and desktop highlighting styles. my hunch is that it has to do with how the css variables are loaded in mobile. will keep looking into tho!

as a short-term fix, you can delete this line here where the dark hightlight color is instantiated and then use the styles settings to set a new value. i've tested and this is a workaround: https://github.com/colineckert/obsidian-things/blob/main/theme.css#L247