search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
707 stars 60 forks source link

PDF Exports corrupt the search text when Things 3 theme is enabled #165

Open madukan opened 3 months ago

madukan commented 3 months ago

I started using the Things 3 theme a while back (When Things 2 was there) and am a happy camper! Now it is kind of can't live without as am quite used to the clarity, simplicity and aesthetics it provides.

Exporting PDFs when I need to share the pages is how I interact with non-Obsidian users (or those who don't understand or don't want to use Markdown). Also PDFs are quite searchable in file systems and appreciated by the many.

One (rather unfortunate) issue I found is when Things 3 theme is enabled, the exported PDF has text that is corrupted. Highlights of the text is not proper. (When selecting the text on the PDF, highlight happens below the actual text).

Would you be able to kindly have a look at this issue as the exported PDF needs to be like for like in the original text and text extraction? I checked this issue in the Sandbox without Things 3, and then in my vault with and without Things 3, and that is how I isolated the matter.

If this PDF search can be made possible in the exported PDF when Things 3 theme is enabled, I would appreciate it very much. Keep up the great work! Things 3 is awesome! (I actually started using the Things 3 app because of this Theme too!!)

madukan commented 3 months ago

Thought I would add some steps to easily re-produce the issue:

Steps to re-produce the issue:

  1. Open Obsidian. Click Help > Open SandBox Vault. Now that will give a fresh start without any plugins, themes or custom Javascripts so that your output of the PDF is clean.
  2. Next, export the PDF in any page. Click File > Export to PDF. Save the PDF file, open it again. Highlight the PDF text and copy (CTRL+C on Windows or CMD+C on Mac).
  3. Then kick off the notes editing tool of your choice. (Or you can paste the copied text back into the Obsidian sandbox vault page itself as it won't be saved when you close the vault)
  4. Observe the text and compare to the original text in the PDF.
  5. Now, When you do the above text without the Things 3 theme, everything looks normal. But, in Obsidian, goto Settings > Appearance > Themes. Click Manage, and install Things 3 theme.
  6. With the Things 3 theme selected in the Themes drop down box, do the steps 2 to 4 above. You will notice the issue.

Expected outcome:

  1. When highlighting the text in the exported PDF, the actual text/sentense to be highlighted.
  2. The copied and pasted text to be the same as in the original PDF.
I’m interested in Obsidian
First of all, tell me a little bit about what's your experience with note-taking apps like?
I have no prior experience
I’ve used note-taking apps like Evernote and OneNote I have used plain-text based apps

Actual outcome:

  1. When highlighting the text, the highlight happens under the text/sentence, in a thin line.
  2. Corrupted text, and no relation to the original text.
sppa desab txet-nialp desu evah I
etoNenO dna etonrevE ekil sppa gnikat-eton desu evʼI
ecneirepxe roirp on evah I
?ekil sppa gnikat-eton htiw ecneirepxe ruoy s'tahw tuoba tib elttil a em llet ,lla fo tsriF
naidisbO ni detseretni mʼI
tseT