search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

feat: allow inline code blocks color customisation #79

Closed Fricounet closed 2 years ago

Fricounet commented 2 years ago

Add a new 'Style Setting' to change the inline code blocks color for Light and Dark themes.

For example:

image

Light:

image

Dark:

image
colineckert commented 2 years ago

Hey, thanks for creating the PR. This setting here actually refers to styling the font color of these blockquotes:

Screen Shot 2022-08-14 at 5 51 19 PM

I don't have a style setting for code block color, though can consider adding one if it's something you really need. Thanks!

Fricounet commented 2 years ago

Oh! My bad, I was not aware these blockquotes existed in Obsidian so I thought there were linked to the ` you can use to create inline code blocks ^^

If you are fine with the customisation of code blocks, I feel like it could be a nice addition. In my opinion, the current color used does not stand out much and is pretty easy to miss when scrolling the text.

I will revert my change and push a commit to introduce their customisation. I was not sure how to implement that since the color is different between the dark and lights themes. I tried to do something similar as what you did for 'Tag background color' but tell me if that is not how it should be done.

And if you do not want to implement this, feel free to close my PR :D

colineckert commented 2 years ago

Thanks, @Fricounet - this is a great addition to the customization options! I appreciate the contribution!