search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

tag display error #84

Closed hmu-duc-anh closed 1 year ago

hmu-duc-anh commented 2 years ago

Hello. I've just updated the theme inside Obsidian, and now my tags look like this. It still remain when zooming in/out, and even after restarting Obsidian.

Please have a look at this. Thank you very much!

image

Hbbb commented 2 years ago

Version Information:

Version 0.15.9 (installer 0.15.9)

I'm also seeing this. Tags look like this to me. SCR-20220918-pu8

pavol6999 commented 2 years ago

For the sake of my sanity and OCD please we need a fix

colineckert commented 2 years ago

OK, I just pushed up a possible fix. Can someone on this thread update their theme and check if resolved?

It's working on my end, but I've recently updgraded to the insider build to start working on v2 of the theme for the new Obsidian v0.16 UI, so I'm not 100% sure it solves the issue.

Appreciate the help!

universvm commented 2 years ago

Screenshot 2022-09-20 at 15 42 22 Unfortunately I still have this. I am on version 15.9 @colineckert

hmu-duc-anh commented 2 years ago

OK, I just pushed up a possible fix. Can someone on this thread update their theme and check if resolved?

It's working on my end, but I've recently updgraded to the insider build to start working on v2 of the theme for the new Obsidian v0.16 UI, so I'm not 100% sure it solves the issue.

Appreciate the help!

Hello @colineckert , thank you for your new fix. I'm also on v15.9, and unfortunately, the problem still persist in my case in a "novel" way. As you can see, the tags's head parts now look a bit larger than the tail parts and remain that way as I zoom in and out. image image image

vpark commented 2 years ago

@Nhiet-MD I realize that this is off topic, but how did you generate your YAML content at the top? I'm curious as to how you created a date modified section that updates dynamically

hmu-duc-anh commented 2 years ago

I use a plugin called "Linter" by Victor Tao to create such frontmatter, which updates itself when I press Ctrl/Cmd + S

Selenuix commented 2 years ago

Same thing here, just updated the theme, Obsidian 0.15.9 (updater 0.14.6).

image

marinoffDev commented 2 years ago

heya @colineckert 👋🏻 you are probably already aware of this but just in case..

The issue is still happening but only while the current view is set to "editing":

image

image

However, if you switch to "reading" view, the tags are displaying correctly:

image

image

colineckert commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

Selenuix commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

Working as intended on my side, thank you! 😄

marinoffDev commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

That fixed it on my end as well 🎉Thank you so much!

colineckert commented 2 years ago

Great! Thanks for confirming @Selenuix and @marinoffDev! Closing this issue. I really appreciate everyone's patience and support! ❤️

Selenuix commented 2 years ago

You might consider reopening the issue. Not sure if it's fixed for others but basically:

image

Hope that helped 😄 If others could confirm, that'd be great.

hmu-duc-anh commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

Everything's back to normal in my case. Thanks a lot!

Selenuix commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

Everything's back to normal in my case. Thanks a lot!

Does it work in source mode as well?

hmu-duc-anh commented 2 years ago

hey all, I just pushed another attempt at resolving this bug. It appears to be working for me locally, but can someone please confirm by updating their theme and checking? Thanks!!

Everything's back to normal in my case. Thanks a lot!

Does it work in source mode as well?

I've been using Live Preview this whole time, now you mention it, the tag is indeed weird in Source Mode. image

colineckert commented 2 years ago

Ah, I see, I was missing a selector for legacy source mode. Should be working now if someone can confirm. I'll reopen until the issue is confirmed resolved. Thanks!

Selenuix commented 2 years ago

image

Just updated, but looks like it's still not working. Keep in mind that I'm on another PC right now and that I hadn't updated to post-fix version. Will try again on work laptop tomorrow and let you know.

@Nhiet-MD Update from your side?

UPDATE: it wasn't a device specific thing, still not working after updating

marinoffDev commented 2 years ago

I typically don't use Source Mode, so I never noticed :/ Updated to the new version just now but the issue persists: image

colineckert commented 2 years ago

Hey everyone, have you upgraded to Obsidian 1.0 and Things v2 yet? This issue should no longer be occurring, but please let me know if you run into any bugs. Thanks!

Selenuix commented 2 years ago

Hey everyone, have you upgraded to Obsidian 1.0 and Things v2 yet? This issue should no longer be occurring, but please let me know if you run into any bugs. Thanks!

Fixed on my side, even in source mode. Thank you 😄

Selenuix commented 1 year ago

This should probably be closed now, everything has been fixed.